waynexia commented on code in PR #6336:
URL: https://github.com/apache/arrow-rs/pull/6336#discussion_r1738753091
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -28,6 +31,23 @@ use crate::{
use super::Buffer;
+#[cfg(not(feature = "allocator_api"))]
Review Comment:
Thanks for your information. It looks like `allocator-api2` provides many
things we don't need. And I'm hesitant to add a new dep for the normal case. We
can add it in the future if it turns out that `allocator-api2` suits our use
case well. What we need here is
- Placeholders to standard library things that are not available without
unstable features (`Allocator` and `Global`)
- Wrapped `alloc` and `dealloc` methods
As for now we can define them by ourselves in few lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
