bkietz commented on code in PR #6321:
URL: https://github.com/apache/arrow-rs/pull/6321#discussion_r1738839032
##########
arrow-ipc/src/writer.rs:
##########
@@ -1221,49 +1258,56 @@ pub struct EncodedData {
}
/// Write a message's IPC data and buffers, returning metadata and buffer data
lengths written
pub fn write_message<W: Write>(
+ writer: W,
+ encoded: EncodedData,
+ write_options: &IpcWriteOptions,
+) -> Result<(usize, usize), ArrowError> {
+ write_message_at_offset(writer, 0, encoded, write_options)
+}
+
+fn write_message_at_offset<W: Write>(
Review Comment:
Alternatively, since `write_message` doesn't seem widely used I could just
add the `already_written_len` argument there rather than adding a new fn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
