mapleFU commented on code in PR #13901:
URL: https://github.com/apache/arrow/pull/13901#discussion_r1738923863
##########
cpp/src/arrow/array/validate.cc:
##########
@@ -985,10 +985,22 @@ Status ValidateArrayFull(const Array& array) { return
ValidateArrayFull(*array.d
ARROW_EXPORT
Status ValidateUTF8(const ArrayData& data) {
- DCHECK(data.type->id() == Type::STRING || data.type->id() ==
Type::STRING_VIEW ||
- data.type->id() == Type::LARGE_STRING);
- UTF8DataValidator validator{data};
- return VisitTypeInline(*data.type, &validator);
+ const auto& storage_type =
+ (data.type->id() == Type::EXTENSION)
+ ? checked_cast<const ExtensionType&>(*data.type).storage_type()
+ : data.type;
+ DCHECK(storage_type->id() == Type::STRING || storage_type->id() ==
Type::STRING_VIEW ||
+ storage_type->id() == Type::LARGE_STRING);
+
+ if (data.type->id() == Type::EXTENSION) {
+ const auto& ext_data = std::make_shared<ArrayData>(data);
Review Comment:
```suggestion
ArrayData ext_data(data);
ext_data.type = storage_type;
```
can we do like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
