alamb commented on code in PR #6328:
URL: https://github.com/apache/arrow-rs/pull/6328#discussion_r1740088911
##########
.github/workflows/rust.yml:
##########
@@ -100,6 +100,13 @@ jobs:
run: rustup component add rustfmt
- name: Format arrow
run: cargo fmt --all -- --check
+ - name: Format parquet
+ # Many modules in parquet are skipped, so check parquet separately. If
this check fails, run:
Review Comment:
💯 thank you
> > The only other thing I think is important here is to provide
instructions (as comments) about how to fix the CI check if it fails. E.g. "if
this test fails, run `cargo fmt .....` and check in the result" kind
>
> As a comment in `rust.yml`? Can do. I was also thinking some words in the
[formatting](https://github.com/apache/arrow-rs/blob/master/CONTRIBUTING.md#code-formatting)
section of `CONTRIBUTING.md` would be helpful.
Yes, the reason I think it is useful to include this information is so that
if the CI test fails, the developer can just look at the CI failure report on
github (rather than hunting around in the docs) and know how to fix it.
THis looks good to me -- thank you
https://github.com/apache/arrow-rs/blob/ffd216d57469a33303c0d2ec9b974fd25cc0e0f9/.github/workflows/arrow_flight.yml#L75C37-L76C70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
