kou commented on code in PR #43801:
URL: https://github.com/apache/arrow/pull/43801#discussion_r1739651361
##########
cpp/src/arrow/array/data.cc:
##########
@@ -195,6 +197,7 @@ std::shared_ptr<ArrayData> ArrayData::Slice(int64_t off,
int64_t len) const {
} else {
copy->null_count = null_count != 0 ? kUnknownNullCount : 0;
}
+ copy->statistics = nullptr;
Review Comment:
Hmm. I think that we don't need to do it:
* "Slice() always discards statistics" is simple and easy to understand
* In general, `Slice(0, length)` will not be used because it's just a
`Copy()` and an user should use `Copy()` instead of `Slice(0, length)`
If it may be useful, we can revisit this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
