mapleFU commented on code in PR #43912:
URL: https://github.com/apache/arrow/pull/43912#discussion_r1741085273
##########
cpp/src/arrow/compute/row/row_encoder_internal.cc:
##########
@@ -29,6 +29,51 @@ using internal::FirstTimeBitmapWriter;
namespace compute {
namespace internal {
+Result<std::shared_ptr<KeyEncoder>> MakeKeyEncoder(const TypeHolder&
column_type, std::shared_ptr<ExtensionType>* extension_type, MemoryPool* pool) {
Review Comment:
This can also return `unique_ptr` here. I didn't see the purpose a
shared_ptr being used
Also this function is extracted from `RowEncoder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
