vibhatha commented on PR #43903: URL: https://github.com/apache/arrow/pull/43903#issuecomment-2327762683
> ``` > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[27,15] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[27,15] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[27,15] Unsafe is internal proprietary API and may be removed in a future release > Warning: The following options were not recognized by any processor: '[skipDefs, atfDoNotCache]' > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[27,15] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/BaseAllocator.java:[995,19] [removal] reserve(int) in AllocationReservation has been deprecated and marked for removal > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/BaseAllocator.java:[894,19] [removal] add(int) in AllocationReservation has been deprecated and marked for removal > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[36,23] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[36,23] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[36,23] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[36,23] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[64,46] Unsafe is internal proprietary API and may be removed in a future release > Warning: /build/java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java:[77,16] Unsafe is internal proprietary API and may be removed in a future release > ``` > > Can we ensure we fix the warnings? (Also can we enable warnings-as-errors?) Right, we discussed this earlier as well. We can create a ticket to follow up with this. But in relation to this context, I think we need to sort of organize the warning -> error migration as `Unsafe` components probably need some waiting. But for the rest and for each module I can enable the warnings to errors iteratively. I created a parent issue https://github.com/apache/arrow/issues/43941, and I will update each module upon feasibility and create new issues for cases like `Unsafe` to be fixed when we are supporting minimal JDKs in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
