zanmato1984 commented on code in PR #43931:
URL: https://github.com/apache/arrow/pull/43931#discussion_r1744859891
##########
cpp/src/arrow/compute/row/row_encoder_internal.h:
##########
@@ -83,6 +83,13 @@ struct ARROW_EXPORT KeyEncoder {
static bool IsNull(const uint8_t* encoded_bytes) {
return encoded_bytes[0] == kNullByte;
}
+
+ struct EncoderInfo {
Review Comment:
I would suggest using a more descriptive name - `XxInfo` generally doesn't
give much information about `Xx`. Maybe something like EncodeColumnMeta`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
