vibhatha commented on code in PR #43968:
URL: https://github.com/apache/arrow/pull/43968#discussion_r1745139988
##########
java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java:
##########
@@ -354,6 +355,18 @@ protected boolean compareStructVectors(Range range) {
return false;
}
+ if (leftVector instanceof StructVector || rightVector instanceof
StructVector) {
Review Comment:
Another thing is this visitor interface is used for all vectors, and
specifying a logic just for a single vector type doesn't make much sense.
Further, if we are to check the range considering nulls, it should be for all
vectors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
