paleolimbot commented on issue #604: URL: https://github.com/apache/arrow-nanoarrow/issues/604#issuecomment-2334366601
That is a great point...it was this way initially due to the `ArrowSchema`'s role as both "data type" and "field" (which is data type + name + nullability in most Arrow implementations). Having this be nullable by default is a bit safer since some implementations use the nulability flag to skip checking for nulls and it would result in incorrect behaviour to set that by default. > Obviously, we can add a local variant with an added bool which calls this and then, as needed, follows up with This is probably your best bet for now, but it would be cheap to add `ArrowSchemaSetNullability()` (or maybe more generically, `ArrowSchemaSetFlag(schema, flag, state)`) for better readability when toggling the flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
