kou commented on code in PR #43982:
URL: https://github.com/apache/arrow/pull/43982#discussion_r1746791982
##########
.pre-commit-config.yaml:
##########
@@ -78,6 +78,26 @@ repos:
?^cpp/src/generated/|
?^cpp/thirdparty/|
)
+ - repo: https://github.com/cpplint/cpplint
+ rev: 1.6.1
+ hooks:
+ - id: cpplint
+ name: C++ Lint
+ args:
+ - "--verbose=2"
+ types_or:
+ - c++
+ files: >-
+ ^cpp/
+ exclude: >-
+ (
+ ?\.grpc\.fb\.(cc|h)$|
Review Comment:
Good catch! I missed the file.
It seems that `*windows_compatibility.h` difference is only affected for
`cpp/`.
But we can use cpplint for *windows_compatibility.h` now:
*
https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/windows_compatibility.h
*
https://github.com/apache/arrow/blob/main/cpp/src/parquet/windows_compatibility.h
So this list is valid.
I also missed that R also uses cpplint:
https://github.com/apache/arrow/blob/main/r/lint.sh
Let's work on it as a separated PR.
It seems that the current Python code base doesn't use cpplint.
BTW, I doubt that we need cpplint:
https://github.com/apache/arrow/issues/37396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
