paleolimbot commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1747864472
##########
src/nanoarrow/common/array.c:
##########
@@ -642,6 +673,10 @@ void ArrowArrayViewReset(struct ArrowArrayView*
array_view) {
ArrowFree(array_view->union_type_id_map);
}
+ if (array_view->variadic_buffer_views != NULL) {
+ ArrowFree(array_view->variadic_buffer_views);
Review Comment:
It seems expensive to maintain this member...maybe a function like
`ArrowArrayViewVariadicBufferView(array_view, i)` could materialize a
particular one on demand rather than creating them all at once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
