mapleFU commented on code in PR #44003:
URL: https://github.com/apache/arrow/pull/44003#discussion_r1749228717
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -2225,10 +2245,9 @@ class ByteArrayDictionaryRecordReader final : public
TypedRecordReader<ByteArray
} else {
num_decoded = this->current_decoder_->DecodeArrowNonNull(
static_cast<int>(values_to_read), &builder_);
-
- /// Flush values since they have been copied into the builder
- ResetValues();
Review Comment:
This is a logical change but I don't think it would matter 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]