mapleFU commented on code in PR #44009:
URL: https://github.com/apache/arrow/pull/44009#discussion_r1749483598
##########
cpp/src/parquet/arrow/reader_internal.cc:
##########
@@ -342,21 +342,24 @@ void AttachStatistics(::arrow::ArrayData* data,
static_cast<::parquet::TypedStatistics<ParquetType>*>(statistics);
const ArrowCType min = typed_statistics->min();
const ArrowCType max = typed_statistics->max();
- if (std::is_floating_point<ArrowCType>::value) {
+ if constexpr (std::is_same<ArrowCType, bool>::value) {
+ array_statistics->min = static_cast<bool>(min);
+ array_statistics->max = static_cast<bool>(max);
Review Comment:
Is min-max useful for boolean? Do they only useful for pruning or agg on
same value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
