zeroshade commented on code in PR #114:
URL: https://github.com/apache/arrow-go/pull/114#discussion_r1751121316
##########
arrow/flight/gen.go:
##########
@@ -16,5 +16,5 @@
package flight
-//go:generate protoc --experimental_allow_proto3_optional -I../../../format
--go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative
--go-grpc_opt=paths=source_relative Flight.proto
-//go:generate protoc --experimental_allow_proto3_optional -I../../../format
--go_out=./gen/flight --go-grpc_out=./gen/flight --go_opt=paths=source_relative
--go-grpc_opt=paths=source_relative FlightSql.proto
+//go:generate protoc --experimental_allow_proto3_optional
-I${APACHE_ARROW_FORMAT_DIR} --go_out=./gen/flight --go-grpc_out=./gen/flight
--go_opt=paths=source_relative --go-grpc_opt=paths=source_relative Flight.proto
+//go:generate protoc --experimental_allow_proto3_optional
-I${APACHE_ARROW_FORMAT_DIR} --go_out=./gen/flight --go-grpc_out=./gen/flight
--go_opt=paths=source_relative --go-grpc_opt=paths=source_relative
FlightSql.proto
Review Comment:
that said, it might be better to utilize `buf` instead see the links below
on the `substrait-go` repo for how I did it there to reference and generate the
protobuf from the .proto files in the `substrait-io/substrait` repo
https://github.com/substrait-io/substrait-go/blob/main/doc.go#L9
https://github.com/substrait-io/substrait-go/blob/main/buf.gen.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
