jorisvandenbossche commented on code in PR #43970:
URL: https://github.com/apache/arrow/pull/43970#discussion_r1751530492
##########
.github/workflows/python.yml:
##########
@@ -56,41 +56,41 @@ jobs:
matrix:
name:
- conda-python-docs
- - conda-python-3.9-nopandas
- - conda-python-3.8-pandas-1.0
- - conda-python-3.10-pandas-latest
- - conda-python-3.10-no-numpy
+ - conda-python-3.10-nopandas
+ - conda-python-3.9-pandas-1.5
+ - conda-python-3.11-pandas-latest
+ - conda-python-3.11-no-numpy
include:
- name: conda-python-docs
- cache: conda-python-3.9
+ cache: conda-python-3.10
image: conda-python-docs
- title: AMD64 Conda Python 3.9 Sphinx & Numpydoc
- python: 3.9
- - name: conda-python-3.9-nopandas
- cache: conda-python-3.9
+ title: AMD64 Conda Python 3.10 Sphinx & Numpydoc
+ python: "3.10"
+ - name: conda-python-3.10-nopandas
+ cache: conda-python-3.10
image: conda-python
- title: AMD64 Conda Python 3.9 Without Pandas
- python: 3.9
- - name: conda-python-3.8-pandas-1.0
- cache: conda-python-3.8
+ title: AMD64 Conda Python 3.10 Without Pandas
+ python: "3.10"
+ - name: conda-python-3.9-pandas-1.5
+ cache: conda-python-3.9
image: conda-python-pandas
- title: AMD64 Conda Python 3.8 Pandas 1.0
- python: 3.8
- pandas: "1.0"
- numpy: 1.16
- - name: conda-python-3.10-pandas-latest
- cache: conda-python-3.10
+ title: AMD64 Conda Python 3.9 Pandas 1.5
+ python: 3.9
+ pandas: "1.5"
+ numpy: 1.24
Review Comment:
Given this is meant to test somewhat the minimum supported version (I
assume), I would maybe take 1.19 for numpy, if we look at what numpy version
supported Python 3.9.
Of course, if we look at something similar as pandas 1.5 in terms of when it
was released, then 1.23 or 1.24 also makes sense.
We also declare `"numpy >= 1.16.6"` in pyproject.toml, which can be updated.
(given we don't really have issues regularly with older numpy, I think I
personally lean to be more conservative)
##########
dev/tasks/tasks.yml:
##########
@@ -1530,11 +1529,11 @@ tasks:
############################## Integration tests ############################
-{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.8",
"1.0", "1.19", True),
- ("3.9",
"latest", "latest", False),
- ("3.10",
"latest", "1.26", False),
+{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.9",
"1.5", "1.24", True),
Review Comment:
(same here for which numpy version to use)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
