assignUser commented on code in PR #603:
URL: https://github.com/apache/arrow-nanoarrow/pull/603#discussion_r1755006009
##########
docker-compose.yml:
##########
@@ -48,12 +46,10 @@ services:
command: "/bin/bash /build-docs.sh /nanoarrow"
integration:
- # Based on an arrow-dev repo image that is amd64 only
- image: ${REPO}:integration-amd64
+ # Don't cache here (building the image takes about the same amount of time
+ # as downloading on CI)
Review Comment:
That's probably because the base image is hosted on dockerhub (and pretty
big iirc), in my experience things on ghcr.io have much better download
characteristics. Though maybe the build is just that fast too ^^
##########
.github/workflows/integration.yaml:
##########
@@ -21,14 +21,21 @@ on:
push:
branches:
- main
+ - 'maint-**'
Review Comment:
```suggestion
- 'maint-*'
```
Probably not an issue but I'd say `**` only makes sense for paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
