danepitkin commented on code in PR #44056:
URL: https://github.com/apache/arrow/pull/44056#discussion_r1759031313
##########
java/flight/flight-core/src/main/java/org/apache/arrow/flight/SetSessionOptionsResult.java:
##########
@@ -45,12 +45,14 @@ static ErrorValue
fromProtocol(Flight.SetSessionOptionsResult.ErrorValue s) {
return values()[s.getNumber()];
}
+ @SuppressWarnings("EnumOrdinal")
Flight.SetSessionOptionsResult.ErrorValue toProtocol() {
return Flight.SetSessionOptionsResult.ErrorValue.values()[ordinal()];
}
}
/** Per-option extensible error response container. */
+ @SuppressWarnings("JavaLangClash")
Review Comment:
+1 for renaming it, if it's not an external API change in some way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
