zanmato1984 commented on code in PR #44116: URL: https://github.com/apache/arrow/pull/44116#discussion_r1759663811
########## cpp/src/arrow/util/simd.h: ########## @@ -27,18 +27,25 @@ #else // gcc/clang (possibly others) -# if defined(ARROW_HAVE_BMI2) +# if defined(ARROW_HAVE_BMI2) || defined(ARROW_HAVE_RUNTIME_BMI2) Review Comment: I try to find some common place to put simd specific code and found this one. However it seems this file is only adapting the static simd optimizations, thus the additions of the `ARROW_HAVE_RUNTIME*` which are for dynamic simd optimizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
