joellubi commented on code in PR #44115: URL: https://github.com/apache/arrow/pull/44115#discussion_r1759723770
########## dev/flight-integration/flight/Flight.pb.go: ########## Review Comment: We do, and I was originally using them first started prototyping. As a matter of principle though, I think that this module should avoid relying on any existing arrow implementations (arrow-go in this case) as it could introduce circular logic in tests and make that particular implementation authoritative instead of this suite. If we only use the generated stubs from arrow-go, that's fine but from `go.mod`'s perspective the entirety of arrow-go is still a dependency. It ends up being the developer's responsibility to not accidentally use non-generated code. By rebuilding the stubs for this module, the arrow-go dependency is removed entirely making the constraint explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
