thisisnic commented on issue #44089: URL: https://github.com/apache/arrow/issues/44089#issuecomment-2351128534
I have mixed feelings - I'm generally opposed to changing how something has worked for a long time given that other users may be depending on it or working around it , but in favour of matching base R when we are emulating their functions. @amoeba I'm a bit rusty with the codebase - if we were to do this, how complex would it be to implement? Note: we allow NaN to be treated as NA on Arrow Datum objects, e.g. ``` r library(arrow) ``` ``` r my_vec <- c(42, NA, NaN) is.na(my_vec) #> [1] FALSE TRUE TRUE ``` ``` r my_arrow_array <- Array$create(my_vec) is.na(my_arrow_array) #> Array #> <bool> #> [ #> false, #> true, #> true #> ] ``` I think, given the above behaviour that we have chosen to implement, if this isn't too complex and someone is willing to implement it, we could totally look into supporting it. Could we perhaps have it as an option? Or something else? Keen to hear what others think though. Some tangentially related PRs: - https://github.com/apache/arrow/issues/29038 - https://github.com/apache/arrow/issues/29626 - https://github.com/apache/arrow/issues/27883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
