nealrichardson commented on code in PR #44124: URL: https://github.com/apache/arrow/pull/44124#discussion_r1760162765
########## r/tools/nixlibs.R: ########## @@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = "https://raw.githubusercontent.com/apa # Try a remote allowlist so that we can add/remove without a release suppressWarnings(readLines(allowed)), # Fallback to default: allowed only on Ubuntu and CentOS/RHEL - error = function(e) c("ubuntu", "centos", "redhat", "rhel") + error = function(e) c("ubuntu", "centos", "redhat", "rhel", "rocky", "opensuse-leap") Review Comment: I don't recall the history on this, but the local copy of the allowlist should be present here, right? Can we fall back to `readLines("nixlibs-allowlist.txt")` (or whatever path it is relative to cwd)? That way we only have to track this in one place. Also we should update the comment on the line above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
