nealrichardson commented on a change in pull request #9665:
URL: https://github.com/apache/arrow/pull/9665#discussion_r591703013
##########
File path: r/tests/testthat/test-Table.R
##########
@@ -359,9 +359,9 @@ test_that("table() auto splices (ARROW-5718)", {
})
test_that("Validation when creating table with schema (ARROW-10953)", {
- tab <- Table$create(data.frame(), schema = schema(a = int32()))
- skip("This segfaults")
- expect_identical(dim(as.data.frame(tab)), c(0L, 1L))
+ expect_error(Table$create(data.frame(), schema = schema(a = int32())))
Review comment:
Should we assert the error messages, just to make sure it looks like we
want?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
