felipecrv commented on code in PR #44090:
URL: https://github.com/apache/arrow/pull/44090#discussion_r1762081475
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -3389,6 +3389,9 @@ struct AwsInstance {
ARROW_LOG(WARNING)
<< " arrow::fs::FinalizeS3 was not called even though S3 was
initialized. "
"This could lead to a segmentation fault at exit";
+ auto leaked_ptr = new
std::shared_ptr<S3ClientFinalizer>(GetClientFinalizer());
Review Comment:
it took me a while to understand this wasn't like a make_shared. you could
use `auto *` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
