pitrou commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1763377104
##########
cpp/src/arrow/util/decimal.cc:
##########
@@ -521,6 +726,23 @@ std::string Decimal128::ToString(int32_t scale) const {
return str;
}
+static inline void ShiftAndAdd(std::string_view input, uint32_t* out) {
Review Comment:
This looks like a copy-paste job but I don't understand why it's useful.
Converting a string to decimal32 or decimal64 shouldn't require multiple
passes, so this should definitely be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
