alamb commented on issue #6408: URL: https://github.com/apache/arrow-rs/issues/6408#issuecomment-2356131536
> The slice maybe can't be eliminated until the epic https://github.com/apache/datafusion/issues/7065 is finished... FWIW the slice that I looked at in https://github.com/apache/datafusion/pull/12092#issuecomment-2354023193 is a different one: https://github.com/apache/datafusion/blob/a08f923c2acb1a46614970231d9a672c36ce3ad2/datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs#L435-L438 (This is called once for each distinct group in each batch being aggregates, which is quite bad -- the better way to solve this is to implement a Min/Max accumulator for strings that avoids slicing at all, which we are tracking in https://github.com/apache/datafusion/issues/6906) I think the fact that slice is used many different places makes it all the more important to optimize in arrow-rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
