bkietz commented on code in PR #609:
URL: https://github.com/apache/arrow-nanoarrow/pull/609#discussion_r1763530572
##########
src/nanoarrow/ipc/decoder_test.cc:
##########
@@ -984,7 +984,13 @@ TEST_P(ArrowSchemaParameterizedTestFixture,
NanoarrowIpcNanoarrowFooterRoundtrip
EXPECT_EQ(
ArrowIpcEncoderFinalizeBuffer(encoder.get(), /*encapsulate=*/false,
buffer.get()),
NANOARROW_OK);
+
+#ifdef __BIG_ENDIAN__
+ uint32_t footer_size_le = bswap32(static_cast<int32_t>(buffer->size_bytes));
Review Comment:
I believe byteswap functions take only unsigned integers
```suggestion
uint32_t footer_size_le =
bswap32(static_cast<uint32_t>(buffer->size_bytes));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
