bkietz commented on code in PR #615:
URL: https://github.com/apache/arrow-nanoarrow/pull/615#discussion_r1764046756
##########
docs/source/roadmap.md:
##########
@@ -27,10 +27,9 @@ have not yet been scheduled for implementation.
## C library
- **Type coverage**: The C library currently provides support for all types
that
- are available via the Arrow C Data interface. When the recently-added run-end
- encoded (REE) types and potentially forthcoming string view/list view types
- are available via the Arrow C Data interface, support should be added in
- nanoarrow as well.
+ are available via the Arrow C Data interface. Now that the run-end encoded
(REE)
+ types and string view/list view types are available via the Arrow C Data
interface,
+ support should be added in nanoarrow as well.
Review Comment:
```suggestion
are available via the Arrow C Data interface except run-end encoded (REE)
types and string view/list view types. Support for these should be added in
nanoarrow as well.
```
##########
docs/source/roadmap.md:
##########
@@ -42,6 +41,10 @@ have not yet been scheduled for implementation.
however, including them in the default test suite complicates release
verification
for some users and prevents testing in environments where Arrow C++ does not
currently build (e.g., WASM, compilers without C++17 support).
+- **Test verbosity**: Tests for the C library were written before testing
utilities
+ in the `nanoarrow_testing` library were available (and before there was a
+ `nanoarrow_testing` library in which to put new ones). As a result, some of
them
+ are very verbose and can be difficult to read. W
Review Comment:
Unfinished thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
