paleolimbot commented on code in PR #550:
URL: https://github.com/apache/arrow-nanoarrow/pull/550#discussion_r1765510281
##########
python/tests/test_c_array.py:
##########
@@ -610,3 +622,91 @@ def test_c_array_duration():
d2_duration_in_ms,
d3_duration_in_ms,
]
+
+
+def test_device_array_errors():
+ from nanoarrow.device import DeviceType, resolve
+
+ try:
+ cuda_device = resolve(DeviceType.CUDA, 0)
+ except ValueError:
+ pytest.skip("CUDA device not available")
Review Comment:
That is magic!
VSCode's testing integration gives bright red Xs for skips that happen in
fixtures so I moved the actual skip to the test...but still a huge improvement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
