zeroshade commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1765548463
##########
cpp/src/arrow/util/decimal.cc:
##########
@@ -521,6 +726,23 @@ std::string Decimal128::ToString(int32_t scale) const {
return str;
}
+static inline void ShiftAndAdd(std::string_view input, uint32_t* out) {
Review Comment:
simplified this for decimal32 (decimal64 is able to just use the existing
implementation used for the other types by just using a size of 1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
