wjones127 commented on code in PR #6413:
URL: https://github.com/apache/arrow-rs/pull/6413#discussion_r1765965617
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -8121,9 +8109,9 @@ mod tests {
let casted_array = cast(&array, &decimal_type).unwrap();
let decimal_arr = casted_array.as_primitive::<Decimal128Type>();
- assert_eq!("1123450", decimal_arr.value_as_string(0));
- assert_eq!("2123450", decimal_arr.value_as_string(1));
- assert_eq!("3123450", decimal_arr.value_as_string(2));
+ assert_eq!("11234560", decimal_arr.value_as_string(0));
+ assert_eq!("21234560", decimal_arr.value_as_string(1));
+ assert_eq!("31234560", decimal_arr.value_as_string(2));
Review Comment:
I'm not sure this behavior change is actually what we want 🤔
See my comment in this issue:
https://github.com/apache/arrow-rs/issues/5793#issuecomment-2359709004
If we do commit this, we should mark this as `breaking-change`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
