WillAyd commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1766053145
##########
src/nanoarrow/common/array.c:
##########
@@ -642,6 +673,10 @@ void ArrowArrayViewReset(struct ArrowArrayView*
array_view) {
ArrowFree(array_view->union_type_id_map);
}
+ if (array_view->variadic_buffer_views != NULL) {
+ ArrowFree(array_view->variadic_buffer_views);
Review Comment:
My mistake - I think I misinterpreted what you were asking for in
https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1759449160
Fusing all this feedback together, I think I should just be creating the
`ArrowBufferView` on the fly within `ArrowArrayViewBuffer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
