CurtHagenlocher commented on code in PR #2169:
URL: https://github.com/apache/arrow-adbc/pull/2169#discussion_r1767246316
##########
go/adbc/driver/snowflake/connection.go:
##########
@@ -239,13 +261,13 @@ func (c *connectionImpl) GetCurrentDbSchema() (string,
error) {
// SetCurrentCatalog implements driverbase.CurrentNamespacer.
func (c *connectionImpl) SetCurrentCatalog(value string) error {
- _, err := c.cn.ExecContext(context.Background(), "USE DATABASE ?",
[]driver.NamedValue{{Value: value}})
+ _, err := c.cn.ExecContext(context.Background(), fmt.Sprintf("USE
DATABASE %s", value), nil)
Review Comment:
(I also feel obliged to point out that any single quotes in the identifier
would need to be escaped in that variant.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
