westonpace commented on a change in pull request #9533: URL: https://github.com/apache/arrow/pull/9533#discussion_r592272622
########## File path: cpp/src/arrow/vendored/ProducerConsumerQueue.h ########## @@ -123,7 +123,7 @@ struct ProducerConsumerQueue { return false; } - // move the value at the front of the queue to given variable + // move (or copy) the value at the front of the queue to given variable Review comment: This was a mistake on my part to add it back in. I've pulled it back out. I hadn't realized you had made some changes and I was getting confused during the rebase since I didn't expect any changes and I put this back in by accident. You are right, it is always a move. I originally had my logic reversed in my head. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org