bkietz commented on code in PR #6426:
URL: https://github.com/apache/arrow-rs/pull/6426#discussion_r1768801725
##########
arrow-ipc/regen.sh:
##########
@@ -99,31 +102,31 @@ for f in `ls *.rs`; do
fi
echo "Modifying: $f"
- sed -i '' '/extern crate flatbuffers;/d' $f
- sed -i '' '/use self::flatbuffers::EndianScalar;/d' $f
- sed -i '' '/\#\[allow(unused_imports, dead_code)\]/d' $f
- sed -i '' '/pub mod org {/d' $f
- sed -i '' '/pub mod apache {/d' $f
- sed -i '' '/pub mod arrow {/d' $f
- sed -i '' '/pub mod flatbuf {/d' $f
- sed -i '' '/} \/\/ pub mod flatbuf/d' $f
- sed -i '' '/} \/\/ pub mod arrow/d' $f
- sed -i '' '/} \/\/ pub mod apache/d' $f
- sed -i '' '/} \/\/ pub mod org/d' $f
- sed -i '' '/use core::mem;/d' $f
- sed -i '' '/use core::cmp::Ordering;/d' $f
- sed -i '' '/use self::flatbuffers::{EndianScalar, Follow};/d' $f
+ sed --in-place='' '/extern crate flatbuffers;/d' $f
Review Comment:
I don't know why but bash/sed produced an error for me until I made this
substitution
```
sed: can't read /extern crate flatbuffers;/d: No such file or directory
```
Reading the man page, it seems like the expected invocation for the short
flag is `-ibackup`, equivalent to `--inplace=backup` (or `-i`, equivalent to
`--inplace=''`)
```
-i[SUFFIX], --in-place[=SUFFIX]
edit files in place (makes backup if SUFFIX supplied)
```
Should I replace this with
```suggestion
sed -i '/extern crate flatbuffers;/d' $f
```
##########
arrow-ipc/Cargo.toml:
##########
@@ -39,7 +39,7 @@ arrow-buffer = { workspace = true }
arrow-cast = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
-flatbuffers = { version = "24.3.25", default-features = false }
+flatbuffers = { default-features = false, path =
"../../flatbuffers/rust/flatbuffers" }
Review Comment:
This will be removed before the PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
