bkietz commented on code in PR #627:
URL: https://github.com/apache/arrow-nanoarrow/pull/627#discussion_r1768858730
##########
src/nanoarrow/common/array.c:
##########
@@ -1298,6 +1298,15 @@ static int ArrowArrayViewValidateFull(struct
ArrowArrayView* array_view,
if (array_view->storage_type == NANOARROW_TYPE_DENSE_UNION ||
array_view->storage_type == NANOARROW_TYPE_SPARSE_UNION) {
+ struct ArrowBufferView type_ids;
+ type_ids.size_bytes = array_view->length * sizeof(int8_t);
Review Comment:
:smile:
##########
src/nanoarrow/common/array.c:
##########
@@ -1298,6 +1298,15 @@ static int ArrowArrayViewValidateFull(struct
ArrowArrayView* array_view,
if (array_view->storage_type == NANOARROW_TYPE_DENSE_UNION ||
array_view->storage_type == NANOARROW_TYPE_SPARSE_UNION) {
+ struct ArrowBufferView type_ids;
Review Comment:
To make things clearer/consistenter, should we name this `sliced_type_ids`
or so? (and rename `minimal_offsets -> sliced_offsets`)?
##########
src/nanoarrow/common/array.c:
##########
@@ -1298,6 +1298,15 @@ static int ArrowArrayViewValidateFull(struct
ArrowArrayView* array_view,
if (array_view->storage_type == NANOARROW_TYPE_DENSE_UNION ||
array_view->storage_type == NANOARROW_TYPE_SPARSE_UNION) {
+ struct ArrowBufferView type_ids;
Review Comment:
Maybe later it'd be helpful to extract `ArrowArrayViewSlice` which produces
an equivalent array view but with offset 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
