tlm365 commented on PR #6376: URL: https://github.com/apache/arrow-rs/pull/6376#issuecomment-2365066852
> Thank you very much @tlm365 -- this looks great. > > I was reviewing this PR and I had the code checked out locally, so I took the liberty of making a few changes: > > 1. I fixed clippy (was failing due to using deprecated functions) > 2. I updated the comments / added an example to ease the transition (passing `None` as the flags argument results in type inference errors without some type help) > 3. Improved the comments in general making it clearer what regexp_is_match does and how it is related to `regexp_match` @alamb it looks very nice 👍 thank you so much for this update! ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
