kou commented on code in PR #44179:
URL: https://github.com/apache/arrow/pull/44179#discussion_r1769663320
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions
*options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
+ *
+ * Since: 18.0.0
+ */
+void
+gaflight_call_options_set_timeout(GAFlightCallOptions *options,
+ const gint64 *value)
Review Comment:
```suggestion
gdouble timeout)
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions
*options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
Review Comment:
```suggestion
* Set the timeout in seconds.
*
* An optional timeout for this call. Negative durations
* mean an implementation-defined default behavior will be used
* instead. This is the default value.
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions
*options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
Review Comment:
```suggestion
* @timeout: The timeout in seconds.
```
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -294,6 +294,23 @@ gaflight_call_options_foreach_header(GAFlightCallOptions
*options,
}
}
+/**
+ * gaflight_call_options_set_timeout:
+ * @options: A #GAFlightCallOptions.
+ * @value: The timeout value (in seconds).
+ *
+ * Set the timeout (in seconds).
+ *
+ * Since: 18.0.0
+ */
+void
+gaflight_call_options_set_timeout(GAFlightCallOptions *options,
+ const gint64 *value)
+{
+ auto flight_options = gaflight_call_options_get_raw(options);
+ flight_options->timeout = arrow::flight::TimeoutDuration(*value);
Review Comment:
```suggestion
flight_options->timeout = arrow::flight::TimeoutDuration(timeout);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
