duongcongtoai commented on code in PR #6090:
URL: https://github.com/apache/arrow-rs/pull/6090#discussion_r1771942607
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -2075,20 +2181,18 @@ mod test {
]),
expected_min: struct_array(vec![
(Some(true), Some(1)),
- (Some(true), Some(0)),
+ (Some(false), Some(0)),
(None, None),
]),
expected_max: struct_array(vec![
(Some(true), Some(3)),
- (Some(true), Some(0)),
+ (Some(true), Some(5)),
(None, None),
]),
};
// Due to https://github.com/apache/datafusion/issues/8334,
// statistics for struct arrays are not supported
Review Comment:
maybe we remove this comment after this was resolved
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -2075,20 +2181,18 @@ mod test {
]),
expected_min: struct_array(vec![
(Some(true), Some(1)),
- (Some(true), Some(0)),
+ (Some(false), Some(0)),
(None, None),
]),
expected_max: struct_array(vec![
(Some(true), Some(3)),
- (Some(true), Some(0)),
Review Comment:
original values was
```
(Some(true), Some(0)),
(Some(false), Some(5)),
(None, None),
```
Then isn't min should be `Some(false), Some(5)` and max should be
`Some(true),Some(0)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
