ngli-me commented on code in PR #6445:
URL: https://github.com/apache/arrow-rs/pull/6445#discussion_r1772359164
##########
arrow-string/src/like.rs:
##########
@@ -158,7 +158,9 @@ fn like_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) ->
Result<BooleanArray, Arr
/// This trait helps to abstract over the different types of string arrays
/// so that we don't need to duplicate the implementation for each type.
pub trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized {
+ /// Returns true if all data within this array is ASCII
Review Comment:
```suggestion
/// Returns true if all data within this string array is ASCII
```
Maybe redundant, so feel free to ignore. I see this matches the format of
the other comments on `is_ascii` functions, but my thought is that this is
slightly different since its for the `StringArrayType` trait specifically.
Otherwise, LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
