zuyu commented on PR #44191: URL: https://github.com/apache/arrow/pull/44191#issuecomment-2370007312
Thank you for the comments. This *draft* PR was just to let the CI verify the correctness of the refactor. It does not need to get merge, and it seems no performance regressions. 😊 I do agree that sometimes `goto` is useful, and even necessary. Like @felipecrv said, I do observe some CSV parser uses an enum to represent the parsing states, and thus a huge `switch` statement for the state machine, but seems too complicate. Finally, I really appreciate the code quality of the CSV parser by @pitrou. It is really easier to follow than the above parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
