rok commented on code in PR #44070:
URL: https://github.com/apache/arrow/pull/44070#discussion_r1773062711
##########
python/pyarrow/tests/test_extension_type.py:
##########
@@ -1926,3 +1926,50 @@ def test_bool8_scalar():
assert pa.scalar(1, type=pa.bool8()).as_py() is True
assert pa.scalar(2, type=pa.bool8()).as_py() is True
assert pa.scalar(None, type=pa.bool8()).as_py() is None
+
+
[email protected]("storage_type", (
+ pa.utf8(), pa.large_utf8(), pa.string_view(), pa.string(),
pa.large_string()))
+def test_json(storage_type, pickle_module):
+ data = ['{"a": 1}', '{"b": 2}', None]
+ storage = pa.array(data, type=storage_type)
+ json_type = pa.json_(storage_type)
+ json_arr_class = json_type.__arrow_ext_class__()
+
+ assert pa.json_() == pa.json_(pa.utf8())
Review Comment:
I meant to test that `pa.json_()` sets storage to `pa.utf8()` by default and
I'd keep this test. However as noted in
https://github.com/apache/arrow/pull/13901#pullrequestreview-2324294761
disregarding storage type here is not desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
