alamb commented on code in PR #6444: URL: https://github.com/apache/arrow-rs/pull/6444#discussion_r1773568831
########## arrow-ipc/src/convert.rs: ########## @@ -62,12 +66,13 @@ pub fn metadata_to_fb<'a>( pub fn schema_to_fb_offset<'a>( Review Comment: this is also a a public API https://docs.rs/arrow-ipc/latest/arrow_ipc/convert/fn.schema_to_fb_offset.html ########## arrow-ipc/src/convert.rs: ########## @@ -27,14 +27,18 @@ use std::collections::HashMap; use std::fmt::{Debug, Formatter}; use std::sync::Arc; +use crate::writer::DictionaryTracker; use crate::{size_prefixed_root_as_message, KeyValue, Message, CONTINUATION_MARKER}; use DataType::*; /// Serialize a schema in IPC format -pub fn schema_to_fb(schema: &Schema) -> FlatBufferBuilder { +pub fn schema_to_fb<'a>( Review Comment: Unfortunately, this appears to be a public API https://docs.rs/arrow-ipc/latest/arrow_ipc/convert/fn.schema_to_fb.html And thus if we make this change it is a breaking API change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
