alamb commented on issue #6430: URL: https://github.com/apache/arrow-rs/issues/6430#issuecomment-2372014033
> So considering the api consistency, shall we insist on allowing clone for sliced BooleanArray? No, I think we should follow the model of PrimitiveArray rather than cloning implicitly > The proposed solutions are similar -- exposing the underlying two builders. However, the provided two builders are required to be manipulated correctly, which seems not user-friendly, if some bit needs to be set/unset. And I guess it would be better if we add a new method to the BooleanBuilder: I think we should still permit converting `BooleanBuilder` into its two internal builders as well as creating a BooleanBuilder from the two builders - I agree it is not as user friendly but it offers the most control Adding some additional easier to use apis like `BooleanBuilder::set_value` also seems reasonable to me, as we have usercases for them So perhaps we can first focus on more easily converting back / forth between builders, and then we can figure out what additional APIs we could add to the builders to make it easier to use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
