birschick-bq commented on code in PR #2152: URL: https://github.com/apache/arrow-adbc/pull/2152#discussion_r1774211713
########## csharp/src/Drivers/Apache/Impala/ImpalaParameters.cs: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Arrow.Adbc.Drivers.Apache.Impala +{ + /// <summary> + /// Parameters used for connecting to Impala data sources. + /// </summary> + public static class ImpalaParameters + { + public const string HostName = "adbc.impala.host"; + public const string Port = "adbc.impala.port"; + public const string Path = "adbc.impala.path"; + public const string AuthType = "adbc.impala.auth_type"; + public const string DataTypeConv = "adbc.impala.data_type_conv"; + } + + public static class ImpalaAuthTypeConstants + { + public const string None = "none"; + public const string UsernameOnly = "username_only"; + public const string Basic = "basic"; + + public static bool TryParse(string? authType, out ImpalaAuthType authTypeValue) + { + switch (authType?.Trim().ToLowerInvariant()) + { + case null: + case "": + authTypeValue = ImpalaAuthType.Empty; + return true; + case None: + authTypeValue = ImpalaAuthType.None; + return true; + case UsernameOnly: + authTypeValue = ImpalaAuthType.UsernameOnly; + return true; + case Basic: + authTypeValue = ImpalaAuthType.Basic; + return true; + default: + authTypeValue = ImpalaAuthType.Invalid; + return false; + } + } + } + + public enum ImpalaAuthType Review Comment: Refactored the parameter options to be separate from the internal enumeration and parsing methods. ########## csharp/test/Drivers/Apache/Hive2/HiveServer2ParametersTest.cs: ########## @@ -0,0 +1,62 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one or more +* contributor license agreements. See the NOTICE file distributed with +* this work for additional information regarding copyright ownership. +* The ASF licenses this file to You under the Apache License, Version 2.0 +* (the "License"); you may not use this file except in compliance with +* the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ + +using System; +using System.Collections.Generic; +using Apache.Arrow.Adbc.Drivers.Apache.Hive2; +using Xunit; + +namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Hive2 +{ + public class HiveServer2ParametersTest + { + [SkippableTheory] + [MemberData(nameof(GetParametersTestData))] + public void TestParametersParse(string? dataTypeConversion, HiveServer2DataTypeConversion expected, Type? excptionType = default) Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
