alamb commented on code in PR #6452:
URL: https://github.com/apache/arrow-rs/pull/6452#discussion_r1775537174
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -5254,6 +5286,23 @@ mod tests {
}
}
+ #[test]
+ fn test_cast_between_durations() {
Review Comment:
Can you please add additional tests for:
1. Casting between each individual duration type (cover second, millisecond,
microsecond, and nanosecond)
2. Tests where the casting will fail (aka when checked_mul fails)
3. Casting to/from numeric types to Duration types (to ensure that we don't
break the feature by accident in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
