CurtHagenlocher commented on code in PR #2188:
URL: https://github.com/apache/arrow-adbc/pull/2188#discussion_r1776017298
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Parameters.cs:
##########
@@ -24,4 +24,10 @@ public static class DataTypeConversionOptions
public const string None = "none";
public const string Scalar = "scalar";
}
+
+ public static class TlsOptions
+ {
+ public const string AllowInvalidCertificate =
"allowinvalidcertificate";
+ public const string AllowInvalidHostnames = "allowinvalidhostnames";
Review Comment:
I think the comma-delimited set of options is fine vs a bunch of long-named
individual switches, but maybe we can name them `allow_self_signed` and
`allow_hostname_mismatch`?
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2TlsOption.cs:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+
+namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2
+{
+ [Flags]
+ internal enum HiveServer2TlsOption
+ {
+ Empty = 0,
+ AllowInvalidCertificate = 1,
+ AllowInvalidHostnames = 2,
Review Comment:
If we do rename the user-facing options then we should also rename these to
match.
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2TlsOption.cs:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System;
+
+namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2
+{
+ [Flags]
+ internal enum HiveServer2TlsOption
+ {
+ Empty = 0,
+ AllowInvalidCertificate = 1,
+ AllowInvalidHostnames = 2,
+ }
+
+ internal static class TlsOptionsParser
+ {
+
Review Comment:
nit: remove blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
