fsdvh commented on issue #6460: URL: https://github.com/apache/arrow-rs/issues/6460#issuecomment-2376758384
I will try to provide an example of the second issue, but meanwhile, I thought maybe we can change the `flush` method of [BufWriter](https://github.com/apache/arrow-rs/blob/50e9e4927ed4d763c76227c588aa324aa173032e/object_store/src/buffered.rs#L220): ```rust fn poll_flush(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Result<(), Error>> { loop { return match &mut self.state { BufWriterState::Write(write) => { if let Some(write) = write { write.poll_for_capacity(0); } }, BufWriterState::Buffer(_, _) => Poll::Ready(Ok(())), BufWriterState::Flush(_) => panic!("Already shut down"), BufWriterState::Prepare(f) => { self.state = BufWriterState::Write(ready!(f.poll_unpin(cx)?).into()); continue; } }; } } ``` By actually waiting for all downloads to complete we can give a user and ability to use `flush()` + `shutdown()`, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
