kou commented on code in PR #43601:
URL: https://github.com/apache/arrow/pull/43601#discussion_r1778524357
##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -205,7 +206,8 @@ class S3TestMixin : public AwsTestMixin {
ARROW_ASSIGN_OR_RAISE(minio_, GetMinioEnv()->GetOneServer());
client_config_.reset(new Aws::Client::ClientConfiguration());
client_config_->endpointOverride = ToAwsString(minio_->connect_string());
- client_config_->scheme = Aws::Http::Scheme::HTTP;
+ client_config_->scheme = Aws::Http::Scheme::HTTPS;
+ client_config_->verifySSL = false;
Review Comment:
Oh...
OK. Could you use `#if defined(_WIN32) || defined(__APPLE__)` instead of
`#ifdef _WIN32`?
This code may be used on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
