rustyconover commented on code in PR #35679:
URL: https://github.com/apache/arrow/pull/35679#discussion_r1778957169
##########
cpp/src/arrow/flight/transport/grpc/serialization_internal.cc:
##########
@@ -380,6 +382,14 @@ ::grpc::Status FlightDataDeserialize(ByteBuffer* buffer,
return ::grpc::Status(::grpc::StatusCode::INTERNAL,
"Unable to read FlightData body");
}
+ // XXX: due to where we sit, we can't use a custom allocator
+ // XXX: any error here will likely crash or hang gRPC!
+ auto status =
+ util::EnsureAlignment(std::move(out->body), 64,
default_memory_pool())
Review Comment:
Misaligned data pointers can be a significant hurdle when working with
client libraries that require proper alignment. If these libraries offered
better built-in support for data alignment, it would greatly reduce the
challenges for developers.
Ensuring data is aligned by default leads to a smoother, more efficient
developer experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
